close receiver on argument validation failure#8
Merged
michaelficarra merged 3 commits intotc39:mainfrom Mar 12, 2026
Merged
Conversation
ljharb
approved these changes
Mar 12, 2026
michaelficarra
approved these changes
Mar 12, 2026
Member
michaelficarra
left a comment
michaelficarra
left a comment
There was a problem hiding this comment.
LGTM. Since this is clearly uncontroversial, I will merge now and just include a mention in my next presentation to committee.
Member
Author
|
Oh I was gonna ask for approval at the ongoing meeting. Only takes a minute. |
Member
|
@bakkot Sure, if you can get the chairs to give you the time. |
bakkot
commented
Mar 12, 2026
bakkot
commented
Mar 12, 2026
ljharb
added a commit
to es-shims/iterator-helpers
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
Didn't update the implementation, sorry.